reschke commented on code in PR #2032:
URL: https://github.com/apache/jackrabbit-oak/pull/2032#discussion_r1933921226
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -237,6 +238,7 @@ static void setFullGcMode(int fullGcMode) {
private final boolean isFullGCDryRun;
private final boolean embeddedVerification;
private final double fullGCDelayFactor;
+ private long fullGcMaxAgeInMillis;
Review Comment:
can this be "final" for consistency?
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/FullGCHelper.java:
##########
@@ -60,6 +63,16 @@ public static void disableFullGCDryRun(final
VersionGarbageCollector vgc) throws
}
}
+ public static VersionGarbageCollector.VersionGCStats gc(final
VersionGarbageCollector gc, final long maxRevisionAge, final TimeUnit unit)
throws IOException {
+ gc.setFullGcMaxAge(maxRevisionAge, unit); // set full gc max age
+ final VersionGarbageCollector.VersionGCStats stats =
gc.gc(maxRevisionAge, unit);
+ if (stats.skippedFullGCDocsCount != 0) {
+ (new Exception("here: " +
stats.skippedFullGCDocsCount)).printStackTrace(System.out);
Review Comment:
stdout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
