rishabhdaim commented on code in PR #2032:
URL: https://github.com/apache/jackrabbit-oak/pull/2032#discussion_r1933957431
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -237,6 +238,7 @@ static void setFullGcMode(int fullGcMode) {
private final boolean isFullGCDryRun;
private final boolean embeddedVerification;
private final double fullGCDelayFactor;
+ private long fullGcMaxAgeInMillis;
Review Comment:
We are setting this in `setFullGcMaxAge`, so it can't be made final.
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -237,6 +238,7 @@ static void setFullGcMode(int fullGcMode) {
private final boolean isFullGCDryRun;
private final boolean embeddedVerification;
private final double fullGCDelayFactor;
+ private long fullGcMaxAgeInMillis;
Review Comment:
We are setting this in `setFullGcMaxAge()`, so it can't be made final.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]