thomasmueller commented on PR #2178: URL: https://github.com/apache/jackrabbit-oak/pull/2178#issuecomment-2721733352
I would prefer a solution that: * Exactly matches the behavior of ImmutableSet.copyOf (specially being read-only, behavior of null entries, concurrency). * Have similar performance (measurably). Here a simple micro-benchmark would help; it doesn't need to be a unit test. * Have similar memory usage (measured). I don't think we need a unit test for that; instead, we could just test with a fixed set of e.g. 100 million entries, and see if it's running OOME at the same memory setting. Also, I would probably not change all 35 files at the same time, but maybe half of those (so in two steps) with one week delay. So in case we break something, we know more exactly where. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
