rishabhdaim commented on PR #2178: URL: https://github.com/apache/jackrabbit-oak/pull/2178#issuecomment-2721780301
@nfsantos thanks for the review. I did try to incorporate some of your review comments in https://github.com/apache/jackrabbit-oak/pull/2178/commits/9876048d5372372672125e8e3a57f1c54e5034f1. However, I agree with @thomasmueller that we should even split this PR into smaller chunks. @thomasmueller does the following sound reasonable to you: `ImmutableSet.copyOf` replaced with `Collections.unmofiableSet(LinkedHashSet(...))`. this ensures that we won't be able to modify it and also the order would remain the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
