rishabhdaim commented on PR #2212: URL: https://github.com/apache/jackrabbit-oak/pull/2212#issuecomment-2785160642
> More investigation is needed: > > * Verify memory usage > > * Verify behavior of null entries > > * Verify with someone that knows the security part @thomasmueller please find reply as below: 1. Memory usage had already been tested along with performance and both Java's LinkedHashSet & ImmutableSet provides similar performance and memory usage. 2. ImmutableSet also throws NPE in case we put null values for `addAll` method, which is again same behaviour of `LinkedHashSet.addAll`. Also, I have added comments for each method explaining whether null value is possible or not. 3. @anchela could you please review from security point of view. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
