rishabhdaim commented on code in PR #2212: URL: https://github.com/apache/jackrabbit-oak/pull/2212#discussion_r2034312655
########## oak-exercise/src/main/java/org/apache/jackrabbit/oak/exercise/security/authorization/models/simplifiedroles/Role.java: ########## @@ -16,8 +16,13 @@ */ package org.apache.jackrabbit.oak.exercise.security.authorization.models.simplifiedroles; +import java.util.Arrays; import java.util.Collections; +import java.util.LinkedHashSet; import java.util.Set; +import java.util.stream.Collectors; +import java.util.stream.Stream; + import org.apache.jackrabbit.guava.common.collect.ImmutableSet; Review Comment: Would remove them in next PR along with ImmutableSet imports ########## oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/composite/CompositeAccessControlManager.java: ########## @@ -18,7 +18,10 @@ import java.security.Principal; import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; Review Comment: Would remove them in next PR along with ImmutableSet imports ########## oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/basic/DefaultSyncConfig.java: ########## @@ -18,10 +18,14 @@ import java.util.Collections; import java.util.HashSet; +import java.util.LinkedHashSet; import java.util.Map; import java.util.Set; +import java.util.stream.Collectors; +import java.util.stream.Stream; import org.apache.jackrabbit.guava.common.collect.ImmutableSet; +import org.apache.jackrabbit.oak.commons.collections.SetUtils; Review Comment: Would remove them in next PR along with ImmutableSet imports -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org