mbaedke commented on code in PR #2380:
URL: https://github.com/apache/jackrabbit-oak/pull/2380#discussion_r2207180674
##########
oak-run/src/main/java/org/apache/jackrabbit/oak/run/MetricsExporterFixtureProvider.java:
##########
@@ -98,7 +102,14 @@ static class ExportMetricsArgs {
this.pushUri = split.get(1);
if (split.size() > 2) {
- this.pushMap =
Splitter.on(",").omitEmptyStrings().trimResults().withKeyValueSeparator("=").split(split.get(2));
+ this.pushMap = Arrays.stream(split.get(2).split(","))
+ .map(String::trim)
+ .filter(s -> !s.isEmpty())
+ .map(s -> s.split("=", 2))
+ .filter(arr -> arr.length == 2)
+ .collect(Collectors.toMap(
+ arr -> arr[0],
+ arr -> arr[1]));
Review Comment:
As with MemoryDocumentStore I'm concerned about a possible change in the
error handling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
