rishabhdaim commented on code in PR #2380:
URL: https://github.com/apache/jackrabbit-oak/pull/2380#discussion_r2209248797


##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/memory/MemoryDocumentStore.java:
##########
@@ -411,7 +412,10 @@ public void setReadWriteMode(String readWriteMode) {
         }
         lastReadWriteMode = readWriteMode;
         try {
-            Map<String, String> map = Splitter.on(", 
").withKeyValueSeparator(":").split(readWriteMode);
+            Map<String, String> map = Arrays.stream(readWriteMode.split(", "))
+                    .map(s -> s.split(":", 2))
+                    .filter(arr -> arr.length == 2)
+                    .collect(Collectors.toMap(arr -> arr[0], arr -> arr[1]));

Review Comment:
   we are catching `Exception` here and doing nothing for that. I don't think 
it would have any impact.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to