rishabhdaim commented on code in PR #2380:
URL: https://github.com/apache/jackrabbit-oak/pull/2380#discussion_r2213207820
##########
oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/JournalReader.java:
##########
@@ -54,7 +55,13 @@ protected JournalEntry computeNext() {
String line = null;
while ((line = reader.readLine()) != null) {
if (line.indexOf(' ') != -1) {
- List<String> splits = Splitter.on(' ').splitToList(line);
+ List<String> splits;
+ if (line.trim().isEmpty()) {
+ // special case handling for empty lines where we need
to split by space
+ splits =
Arrays.stream(line.split("")).map(String::trim).collect(Collectors.toList());
+ } else {
+ splits = Arrays.stream(line.split("
")).collect(Collectors.toList());
+ }
Review Comment:
Thank @mbaedke for the review, the issue has been fixed in
https://github.com/apache/jackrabbit-oak/pull/2380/commits/d7580c76683337c4f42d301e134fc9aa69a7adbc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
