ChlineSaurus commented on code in PR #2687:
URL: https://github.com/apache/jackrabbit-oak/pull/2687#discussion_r2703530288


##########
oak-core/src/main/java/org/apache/jackrabbit/oak/query/UnionQueryImpl.java:
##########
@@ -568,16 +568,16 @@ public int compare(ResultRowImpl left, ResultRowImpl 
right) {
 
     /**
      * @param row the result row
-     * @return the jcr:score as a double
-     * Precondition: {@link #isScorePresent(Query)} must be true. If the row 
lacks a jcr:score, 0.0 is returned and
-     * the issue is logged.
+     * @return the jcr:score as a double, or 0.0 if the row lacks a score value

Review Comment:
   Oh, fair enough. How would you do this? Add a second feature toggle? Or is 
renaming the existing one enough?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to