thomasmueller commented on code in PR #2687:
URL: https://github.com/apache/jackrabbit-oak/pull/2687#discussion_r2711248063
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/query/UnionQueryImpl.java:
##########
@@ -568,16 +568,16 @@ public int compare(ResultRowImpl left, ResultRowImpl
right) {
/**
* @param row the result row
- * @return the jcr:score as a double
- * Precondition: {@link #isScorePresent(Query)} must be true. If the row
lacks a jcr:score, 0.0 is returned and
- * the issue is logged.
+ * @return the jcr:score as a double, or 0.0 if the row lacks a score value
Review Comment:
There is a large delay between us changing Oak and then enabling the feature
toggle. Also, the changed behavior is not tested currently before the customer.
I think we should try a different approach: we should _enable_ the new behavior
by default, and keep the feature toggle to be able to switch _back_ to the old
behavior where needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
