reschke commented on code in PR #2947:
URL: https://github.com/apache/jackrabbit-oak/pull/2947#discussion_r3405131594
##########
oak-core-spi/src/main/java/org/apache/jackrabbit/oak/spi/toggle/Feature.java:
##########
@@ -60,7 +70,10 @@ private Feature(AtomicBoolean value, Registration
registration) {
* @return the feature toggle.
*/
public static Feature newFeature(String name, Whiteboard whiteboard) {
- AtomicBoolean value = new AtomicBoolean();
+ // by default the initial value is false, but it can be overridden by
a system property
+ AtomicBoolean value = new AtomicBoolean(
+ SystemPropertySupplier.create("oak-feature." + name, false).
Review Comment:
ok, what this intended to help with is this use case:
new feature toggle added, quickly run tests (locally) without any container
I also have seen cases where in the code, a sysprop *is* used to initialize
the feature toggle. (would need to cehck whether this was a singular case). If
that make sense, it would be good to make that pattern consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
