rishabhdaim commented on PR #2947: URL: https://github.com/apache/jackrabbit-oak/pull/2947#issuecomment-4694041240
**Findings outside the diff (impact review follow-up)** **Documentation (`newFeatureWithSystemPropertyDefault`)** — The PR adds an opt-in path for JVM overrides, but user-facing docs still do not describe `newFeatureWithSystemPropertyDefault` or the `oak-feature.<toggleName>` naming. Thread consensus here is to put that in **oak-doc** (feature toggles section) rather than duplicating prose in `AGENTS.md`; a short link from agent guidance is enough if we want discoverability. **Commit-Check / branch policy** — CI still rejects this PR: branch name `OAK-12253` does not match the expected `issue/OAK-12253` pattern, and several commits use non–Conventional Commits subjects (some over the 80-character limit). Squash/reword to conventional messages and rename the branch before merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
