reschke commented on code in PR #3239:
URL: https://github.com/apache/jackrabbit-oak/pull/3239#discussion_r4402930871
##########
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/package-info.java:
##########
@@ -14,7 +14,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-@Version("2.4.0")
+@Version("2.5.0")
Review Comment:
Unhappy.
This is a public API, and it's a bad sign if we add something here that is
for internal use only.
Proposal: leave this class alone, and move the new code into a package below
commons.internal - or do not add it at all - given the fact that these are
one-liners anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
