lweitzendorf commented on code in PR #3239:
URL: https://github.com/apache/jackrabbit-oak/pull/3239#discussion_r4405271617
##########
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/package-info.java:
##########
@@ -14,7 +14,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-@Version("2.4.0")
+@Version("2.5.0")
Review Comment:
Alternatively, I could add methods to every API that exposes `Buffer` and
add an alternative that uses `ByteBuffer`. That would make an expensive
conversion less problematic because callers can avoid it entirely by switching
to the `ByteBuffer` version and we can then deprecate the existing functions
using `Buffer`. That would mean we can avoid changing `Buffer` itself, but we'd
then need to bump all the other packages we're adding methods too:
- spi.persistence.persistentcache: 7.0.0 → 7.1.0
- segment.remote: 3.0.0 → 3.1.0
- segment.remote.persistentcache: 2.1.0 → 2.2.0
- segment.remote.queue: 1.0.0 → 1.1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]