rishabhdaim commented on code in PR #3259:
URL: https://github.com/apache/jackrabbit-oak/pull/3259#discussion_r4469705832
##########
oak-search-elastic/pom.xml:
##########
@@ -59,6 +59,8 @@
org.apache.jackrabbit.oak.plugins.index.elastic.util
</Export-Package>
<Import-Package>
+ <!-- Embedded Commons Logging uses LocationAwareLogger in both
SLF4J generations. -->
+ org.slf4j.spi;version="[1.7,3)",
Review Comment:
I checked the generated manifests and ran the **OSGi** tests _with_ and
_without_ the override.
With SLF4J **1.7.36**, bnd _6.3.1_ generates
**org.slf4j.spi;version="[1.7,2)"** by default.
Without the override, bnd generates _[1.7,2)_, which rejects **SLF4J 2.0**’s
SPI package.
I reproduced the resulting **LocationAwareLogger** loading failure;
restoring [1.7,3) made the tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]