mbaedke commented on code in PR #3259:
URL: https://github.com/apache/jackrabbit-oak/pull/3259#discussion_r4482817423


##########
oak-search-elastic/pom.xml:
##########
@@ -59,6 +59,8 @@
               org.apache.jackrabbit.oak.plugins.index.elastic.util
             </Export-Package>
             <Import-Package>
+              <!-- Embedded Commons Logging uses LocationAwareLogger in both 
SLF4J generations. -->
+              org.slf4j.spi;version="[1.7,3)",

Review Comment:
   Ok, so commons-logging itself has a widened import range there, no problem. 
The AWS SDK apparently only uses org.slf4j.event.Level without calling any 
2.x-specific methods, so it will work de facto with the widened range (and 
apparently it used to work in Oak with 1.x in the past and 2.x now), so I guess 
we can do this. But I'd really prefer if we keep this temporary and go fully 
2.x ASAP.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to