[ 
https://issues.apache.org/jira/browse/OAK-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628862#comment-13628862
 ] 

Michael Dürig commented on OAK-709:
-----------------------------------

In a short f2f discussion Jukka, Angela and myself agreed

* that shadowing as [described above | 
https://issues.apache.org/jira/browse/OAK-709?focusedCommentId=13627983&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13627983]
 is the right behaviour. Implementations wise this means the 
{{PurgeRebaseDiff}} in {{RootImpl}} should favour transient changes in conflict 
cases. The permission related validators will / should catch these later on 
commit. See also OAK-709-shadowing_nodes.patch for a POC of this.

* that for the time being we move the {{PurgeRebaseDiff}} related code to a 
separate utility class. Later we will decide whether it should stay there, move 
back into {{RootImpl}} or should be merged into {{NodeBuilder}} as [described 
above | 
https://issues.apache.org/jira/browse/OAK-709?focusedCommentId=13627994&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13627994].
                
> Consider moving permission evaluation to the node state level
> -------------------------------------------------------------
>
>                 Key: OAK-709
>                 URL: https://issues.apache.org/jira/browse/OAK-709
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: core
>            Reporter: angela
>         Attachments: 
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 
> OAK-709_2.patch, OAK-709_3.patch, OAK-709_4.patch, OAK-709-equals_hack.patch, 
> OAK-709.patch, OAK-709-shadowing_nodes.patch, SecureNodeState.java
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to