[
https://issues.apache.org/jira/browse/OAK-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635205#comment-13635205
]
Michael Dürig commented on OAK-709:
-----------------------------------
Jukka made me aware of a problem when rebasing changes from secure node state
on top of a non secure builder: in some cases secure node states are pushed to
the non secure builder. To better track this problem I specialised
{{OurChangesRebaseDiff}} to only cope with those conflicts that are actually
expected and renamed it to {{SecureNodeRebaseDiff}}. The expected conflicts are
adding an existing node or property. These correspond to the shadowing of an
invisible node or property due to access control restrictions of a session. All
other conflicts should never occur. To validate this an
{{IllegaleStateException}} will be thrown for such other conflicts. Note that
throwing is currently commented out for the delete changed node conflict. The
corresponding method might currently be called due to OAK-781.
With these changes the only place where a secure node state might be pushed
onto a non secure builder is in the add existing node conflict handler. AFAICS
the only case where the {{after}} state could actually be a secure node state
is as the result of a move operation.
See revision 1469339
> Consider moving permission evaluation to the node state level
> -------------------------------------------------------------
>
> Key: OAK-709
> URL: https://issues.apache.org/jira/browse/OAK-709
> Project: Jackrabbit Oak
> Issue Type: Sub-task
> Components: core
> Reporter: angela
> Attachments:
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch,
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch,
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch,
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch,
> OAK-709_2.patch, OAK-709_3.patch, OAK-709_4.patch, OAK-709-equals_hack.patch,
> OAK-709.patch, OAK-709-shadowing_nodes.patch, SecureNodeState.java
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
