[ 
https://issues.apache.org/jira/browse/OAK-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627608#comment-13627608
 ] 

Jukka Zitting commented on OAK-709:
-----------------------------------

bq. IMO conflict handling should not / cannot throw exceptions here

You're right, contrary to my previous thinking having such problems surface 
during an automatic purge instead of the final commit() would be confusing and 
conceptually troublesome.

Correctly persisting such conflicting cases to the underlying branch would 
likely require first _removing_ the existing, read-protected content, which 
might in turn make further SecureNodeState wrapping troublesome since 
accessible parts in the subtree below such a node might become lost. Thus it 
seems to me like we may need to find a way to make the purge logic more 
selective, for example only purging those parts of the tree where such 
troublesome conflicts don't exist or, as a simpler alternative, simply 
disabling the purge logic entirely when such conflicts are detected. That 
shouldn't be a problem since such conflicts would normally be quite rare, 
especially in large imports or other batch operations (that typically are 
performed under an admin user with full read access) where the purge logic is 
most useful.
                
> Consider moving permission evaluation to the node state level
> -------------------------------------------------------------
>
>                 Key: OAK-709
>                 URL: https://issues.apache.org/jira/browse/OAK-709
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: core
>            Reporter: angela
>         Attachments: 
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 
> OAK-709_2.patch, OAK-709_3.patch, OAK-709_4.patch, OAK-709-equals_hack.patch, 
> OAK-709.patch, SecureNodeState.java
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to