[ 
https://issues.apache.org/jira/browse/OAK-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773654#comment-13773654
 ] 

Jukka Zitting commented on OAK-659:
-----------------------------------

Some further updates:
* I added an initial version of {{SegmentNodeStore.merge()}} in revision 
1525154.
* Adjusted many places to use builders and the new NodeStore methods instead of 
branches
* In revision 1525185 I removed the {{NodeBuilder.reset()}} method to prevent 
code that is only given a {{NodeBuilder}} instance from changing it's base 
state. Now only the new {{NodeStore}} methods, including {{NodeStore.reset}} 
can change the base state of a builder.
                
> Move purge logic for transient changes below the NodeBuilder interface
> ----------------------------------------------------------------------
>
>                 Key: OAK-659
>                 URL: https://issues.apache.org/jira/browse/OAK-659
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Michael Dürig
>         Attachments: OAK-659-2.patch, OAK-659.patch
>
>
> Currently transient changes are purged down to a persisted branch once a 
> certain size threshold is hit. This logic currently resides in {{RootImpl}}. 
> However this approach doesn't catch the case where a lot of content is added 
> by a commit hook (e.g. index updates) since commit hooks operate on the 
> {{NodeBuilder}} level which is below {{Root}}. 
> The aim of this issue is to pursue ways to push the purge logic further down 
> below the {{NodeBuilder}} interface. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to