[ 
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710699#comment-14710699
 ] 

Thomas Mueller commented on OAK-3263:
-------------------------------------

According to the "fix version", it just looks like we need it for trunk? If we 
need this (new) feature in the 1.0 or 1.2 branch, please adjust the "fix 
version". We might want to discuss how to backport this. But I would prefer we 
don't backport it, as it's clearly a new feature. In any case, we would need a 
patch for trunk.

> flip the condition and if != INCLUDE then return and leave rest of the code 
> as is

Yes, I would also very much prefer that. It should make the patch much smaller 
(easier to analyze and backport), and simplify reading the code.

> PropertyIndexPlan

Yes, that would be the best place to add this feature. Right now, everything is 
done in the constructor (which is usually not a good idea, but well...).

> Support including and excluding paths for PropertyIndex
> -------------------------------------------------------
>
>                 Key: OAK-3263
>                 URL: https://issues.apache.org/jira/browse/OAK-3263
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: query
>            Reporter: Chetan Mehrotra
>             Fix For: 1.3.6
>
>         Attachments: OAK-3263-prelimary.patch
>
>
> As part of OAK-2599 support for excluding and including paths were added to 
> Lucene index. It would be good to have such a support enabled for 
> PropertyIndexe also



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to