[ 
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716655#comment-14716655
 ] 

Manfred Baedke commented on OAK-3263:
-------------------------------------

Hi [~tmueller],

Thanks for reviewing.

bq. Do the existing unit tests work for you with the patch? For me, many tests 
fail, for example MultipleIndicesTest.checkPathRestrictionConflict. I think 
this is due to the checkPathRestrictionConflict method.

I ran the oak-core tests yesterday without issues. Maybe I did something wrong, 
I'll try again.

This IndexConstants.QUERY_PATH thing comes from it's equivalent in the 
LucenePropertyIndex. I think it should be dropped from both classes 
([~chetanm]?)

> Support including and excluding paths for PropertyIndex
> -------------------------------------------------------
>
>                 Key: OAK-3263
>                 URL: https://issues.apache.org/jira/browse/OAK-3263
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: query
>            Reporter: Chetan Mehrotra
>            Assignee: Manfred Baedke
>              Labels: performance
>             Fix For: 1.3.6
>
>         Attachments: OAK-3263-prelimary.patch, OAK-3263-v2.patch, 
> OAK-3263.patch
>
>
> As part of OAK-2599 support for excluding and including paths were added to 
> Lucene index. It would be good to have such a support enabled for 
> PropertyIndexe also



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to