[ 
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716531#comment-14716531
 ] 

Thomas Mueller commented on OAK-3263:
-------------------------------------

Looking at PathFilter (before the patch): The method name "doFiler" looks like 
a typo, and "do" seems unnecessary. [~chetanm] is it OK if I rename it to 
"filter"? The method uses "includedPath.startsWith(path)", this is wrong, it 
should use "isAncestor". I will fix that and add a test case. I will also fix 
the inconsistent formatting. Chetan, would it be possible for you to enable 
Checkstyle or the IDE feature to check the codestyle? Spaces before "{" are 
missing.


> Support including and excluding paths for PropertyIndex
> -------------------------------------------------------
>
>                 Key: OAK-3263
>                 URL: https://issues.apache.org/jira/browse/OAK-3263
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: query
>            Reporter: Chetan Mehrotra
>            Assignee: Manfred Baedke
>              Labels: performance
>             Fix For: 1.3.6
>
>         Attachments: OAK-3263-prelimary.patch, OAK-3263-v2.patch, 
> OAK-3263.patch
>
>
> As part of OAK-2599 support for excluding and including paths were added to 
> Lucene index. It would be good to have such a support enabled for 
> PropertyIndexe also



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to