[ 
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716653#comment-14716653
 ] 

Thomas Mueller commented on OAK-3263:
-------------------------------------

I think PropertyIndexTest.testPathIncludeExclude has a bug. It uses:

* includedPaths = /test/a
* excludedPaths = /test/a/b

The following test case:
{noformat}
        //path restriction is not an ancestor of excluded path, index may be 
used
        f.setPath("/test2");
        plan = new PropertyIndexPlan("plan", root, index.getNodeState(), f);
        assertTrue(Double.POSITIVE_INFINITY != plan.getCost());
{noformat}

As /test2 is not included, I think the cost should be infinity. Same for the 
next test (f.setPath("/test")).

Instead, I guess both path should be /test/a/x (included), but /test/a is 
excluded (as /test/a/b is excluded).

> Support including and excluding paths for PropertyIndex
> -------------------------------------------------------
>
>                 Key: OAK-3263
>                 URL: https://issues.apache.org/jira/browse/OAK-3263
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: query
>            Reporter: Chetan Mehrotra
>            Assignee: Manfred Baedke
>              Labels: performance
>             Fix For: 1.3.6
>
>         Attachments: OAK-3263-prelimary.patch, OAK-3263-v2.patch, 
> OAK-3263.patch
>
>
> As part of OAK-2599 support for excluding and including paths were added to 
> Lucene index. It would be good to have such a support enabled for 
> PropertyIndexe also



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to