[
https://issues.apache.org/jira/browse/OAK-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693367#comment-15693367
]
Chetan Mehrotra commented on OAK-4898:
--------------------------------------
Thanks [~mreutegg] for the detailed feedback
* Updated javadoc - r1771129
* Switched to {{@Nonnull}} at all places
bq. DocumentNodeStore.canceled() catches an IllegalMonitorStateException.
Probably an leftover from OAK-4687.
Yup removed that
bq. Pre-filtering related classes like FilteringAwareObserver,
FilteringDispatcher and ChangeProcessor have inconsistent contracts for
CommitInfo.
Fixed at all those places
bq. I'm also a bit concerned that required changes to BackgroundObserver have
been moved to a separate issue
Done the changes now in this issue commit itself. Only TODO left is to optimize
the case where compaction of change is done i.e. to have ChangeSet merged
[~egli] I have applied the patch in multiple commits. Changes in
observation/prefiltering code is done in r1771137. Would be helpful if you can
review the commits once
> Allow for external changes to have a CommitInfo attached
> --------------------------------------------------------
>
> Key: OAK-4898
> URL: https://issues.apache.org/jira/browse/OAK-4898
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Chetan Mehrotra
> Assignee: Chetan Mehrotra
> Fix For: 1.6
>
> Attachments: OAK-4898-v1.patch, OAK-4898-v2.patch, OAK-4898-v3.patch,
> OAK-4898-v4.patch
>
>
> Currently the observation logic relies on fact that CommitInfo being null
> means that changes are from other cluster node i.e. external changes.
> We should change this semantic and provide a different way to indicate that
> changes are external. This would allow a NodeStore implementation to still
> pass in a CommitInfo which captures useful information about commit like
> brief summary on what got changed which can be used for pre filtering
> (OAK-4796)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
