[
https://issues.apache.org/jira/browse/OAK-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547630#comment-16547630
]
Marcel Reutegger commented on OAK-7589:
---------------------------------------
[~mattvryan], I reviewed your recent changes on
[github|https://github.com/apache/jackrabbit/compare/trunk...mattvryan:direct-binary-access-with-OAK-7637].
As mentioned by Julian in OAK-7637, 'contentTypeEncoding' should be changed to
'characterEncoding' or 'encoding'. JCR defines two related properties on a
{{nt:resource}}: {{jcr:mimeType}} and {{jcr:encoding}}. So, we could also name
them {{mimeType}} and {{encoding}} in the download options.
Can you please also add some JavaDoc? E.g. mention that encoding is related to
the content type and only makes sense when the binary is text.
I would also make {{BinaryDownloadOptions}} and
{{BinaryDownloadOptionsBuilder}} final. WDYT?
> [DirectBinaryAccess][DISCUSS] Client facing API
> -----------------------------------------------
>
> Key: OAK-7589
> URL: https://issues.apache.org/jira/browse/OAK-7589
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Reporter: Matt Ryan
> Assignee: Matt Ryan
> Priority: Major
>
> From a discussion w/ [~mreutegg]: Suggested that we move the API changes out
> of oak-jcr (i.e. org.apache.jackrabbit.oak.jcr.api.binary.HttpBinaryProvider
> and org.apache.jackrabbit.oak.jcr.api.binary.HttpBinaryDownload to a
> different package to avoid unnecessary API changes to oak-jcr.
> This issue should also be used to discuss how exactly the client facing API
> is designed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
