[ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12459099 ] Chris Howe commented on OFBIZ-510: ----------------------------------
I finally had a chance to thoroughly review this patch and it looks very nice. I really like the effort of consolidating the checkout process but at the same time keeping those pages from being too busy. The patch really feels like it's trying to accomplish two seperate things though, a screen consolidation and then an ajax implementation. I have a bit of constructive criticism on both. Let me address them separately. Screen consolidation: There is rewrite of sorts for CustomerEvents.xml. I'm not sure the reason or need for this. Many people utilize those simple methods and changing their functionality and their method names would most likely break anyone's deployment that utilizes ecommerce. Perhaps a better approach would be to break up the existing simple methods into smaller chuncks where the parent method is calling the smaller chunks. For instnace myMethod a b c turns into: myMethod calls methodA calls methodB calls methodC methodA ... methodB ... methodC ... then you can utilize the chunks you need to accomplish your tasks and won't interfere with others. A similar thing was occurring with OrderScreens.xml. You shouldn't remove/change a screen that someone else may be using. Create your new screen(s) and simply change the controller.xml to point to it instead. Then in a later effort a cleanup can be done. This helps keep the component customizable and functional with simple changes. AJAX implementation: While this works well, it appears to be very unnecessary. The async call is specifically what is keeping this from having the potential to degrade. This same effect can be accomplished with just javascript in a visible/invisible dynamically changing of the css class for the div. You're having the client download a 150+KB JS framework in order to potentially save them from downloading 5-7KB of html. > Anonymous Checkout Refactoring [ ecommerce ] Part #2 > ---------------------------------------------------- > > Key: OFBIZ-510 > URL: http://issues.apache.org/jira/browse/OFBIZ-510 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Affects Versions: SVN trunk > Reporter: Tim Ruppert > Attachments: 3stepAnonCheckoutWithAjax.patch > > > So, now that we're close to completing the Anonymous Checkout Refactoring > Part #1, we are going on to the second phase out of three, which is intended > to make the checkout process even more succint. The final goal is to do > something like I did for one of my customers - http://twpinc.insourcery.com . > This is an old site and is being replaced, so don't worry about the other > functionality - just walk thru the checkout process. > Currently we have a long process that contains these functions / screens: > 1. Personal Info > 2. Shipping Address > 3. Shipping Options > 4. Payment Options > 5. Payment Information (and Billing Address) > 6. Review Order > 7. Order Confirmation > We are going to shorten it up this way: > 1. Personal Info / Shipping Address / Billing Address - with the appropriate > error handling and the check box & action Billing same as shipping) > 2. Shippint Options > 3. Payment Options (if necessary - skip if you only have credit card - or > only one option in general) > 4. Review & Place Order - enter the credit card right here - put error > handling here as well > 5. Order Confirmation > This would be the end of this patch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
