[ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12459107 ] Anil K Patel commented on OFBIZ-510: ------------------------------------
I never said that this patch includes work that belongs to other issue. In accordance with what you said regarding adding more code and files so we don't break other function I added this extra method in this file. Eventually this this method can be used to replace other the other methods that exists in Ofbiz that do something similar. One of the other bad thing about this code is it just almost replicates method that already exists in the same file. If you look at the code in createCustomer method, its almost replica of createUser method that exists in Party component. I have documented these things in the Issue Ofbiz-512. All this code is result of general practice of adding new things and not removing old stuff and creating redundent code. Yes I have added redundancy, Just to prove my good intentions I have also created a Jira Issue to discuss the problem and find a better solution to fix the problem. Processing Payment using async call is lot friendly then doing a full page submit. In the next step we are planning to offer async shipping estimate to user as first step of checkout. While we are contributing our work for review to the community, people can definitely use little polite words to express their ideas. > Anonymous Checkout Refactoring [ ecommerce ] Part #2 > ---------------------------------------------------- > > Key: OFBIZ-510 > URL: http://issues.apache.org/jira/browse/OFBIZ-510 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Affects Versions: SVN trunk > Reporter: Tim Ruppert > Attachments: 3stepAnonCheckoutWithAjax.patch > > > So, now that we're close to completing the Anonymous Checkout Refactoring > Part #1, we are going on to the second phase out of three, which is intended > to make the checkout process even more succint. The final goal is to do > something like I did for one of my customers - http://twpinc.insourcery.com . > This is an old site and is being replaced, so don't worry about the other > functionality - just walk thru the checkout process. > Currently we have a long process that contains these functions / screens: > 1. Personal Info > 2. Shipping Address > 3. Shipping Options > 4. Payment Options > 5. Payment Information (and Billing Address) > 6. Review Order > 7. Order Confirmation > We are going to shorten it up this way: > 1. Personal Info / Shipping Address / Billing Address - with the appropriate > error handling and the check box & action Billing same as shipping) > 2. Shippint Options > 3. Payment Options (if necessary - skip if you only have credit card - or > only one option in general) > 4. Review & Place Order - enter the credit card right here - put error > handling here as well > 5. Order Confirmation > This would be the end of this patch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
