HP, does this look right to you? 

> On Sep 14, 2016, at 8:20 PM, Larry Gritz <l...@larrygritz.com> wrote:
> 
> How does this look?  https://github.com/OpenImageIO/oiio/pull/1490 
> <https://github.com/OpenImageIO/oiio/pull/1490>
> 
> 
>> On Sep 13, 2016, at 9:41 PM, Haarm-Pieter Duiker <l...@duikerresearch.com 
>> <mailto:l...@duikerresearch.com>> wrote:
>> 
>> It looks like that 'adjust_maximum_thr' should be set to 0.0 generally. The 
>> comment from the libRaw changelog is as follows:
>> "
>>            * dcraw_emu's -c parameter now wants numeric (float) argument. 
>> This value
>>              is assigned to params.adjust_maximum_thr.
>>              Use -c 0.0 for dcraw compatibility.
>> 
>> "
>> It's odd that they overrode the -c command line option. With dcraw, that 
>> forces it to write data to stdout. dcraw_emu's -c option has completely 
>> different behavior.
>> 
>> Regardless, setting that struct value to 0.0 seems like it should be done as 
>> a matter of course.
>> 
>> HP
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> On Tue, Sep 13, 2016 at 12:36 AM, Kevin Wheatley <kevin.j.wheat...@gmail.com 
>> <mailto:kevin.j.wheat...@gmail.com>> wrote:
>> So here are the kinds of things we do...
>> 
>>     // Setup as much as possible to mean linear 16 bit
>>     RawProcessor.imgdata.params.output_bps = 16;
>>     RawProcessor.imgdata.params.gamm[0] = 1;
>>     RawProcessor.imgdata.params.gamm[1] = 1;
>>     RawProcessor.imgdata.params.no_auto_bright = 1;
>>     RawProcessor.imgdata.params.adjust_maximum_thr = 0.0;
>> 
>>     // Some parameters effect open() and unpack()
>>     RawProcessor.imgdata.params.use_camera_matrix = <variable>
>>     RawProcessor.imgdata.params.use_camera_wb = <variable>
>> 
>> and some more parts... but those are the important colour ones, other
>> than intercepting the raw colour space buffer and calculating the
>> matrix multiplication ourselves in float to avoid clipping due to
>> white balance/etc.
>> 
>> Kevin
>> _______________________________________________
>> Oiio-dev mailing list
>> Oiio-dev@lists.openimageio.org <mailto:Oiio-dev@lists.openimageio.org>
>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org 
>> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
>> 
>> _______________________________________________
>> Oiio-dev mailing list
>> Oiio-dev@lists.openimageio.org <mailto:Oiio-dev@lists.openimageio.org>
>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
> 
> --
> Larry Gritz
> l...@larrygritz.com <mailto:l...@larrygritz.com>
> 
> 

--
Larry Gritz
l...@larrygritz.com


_______________________________________________
Oiio-dev mailing list
Oiio-dev@lists.openimageio.org
http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org

Reply via email to