In that case -- and considering that the code is plainly setting the parameter 
passed to libraw and I don't know what else I would do -- I'm going to consider 
that a "LGTM" and merge the fix.


> On Sep 20, 2016, at 1:12 PM, Haarm-Pieter Duiker <l...@duikerresearch.com> 
> wrote:
> 
> "they seem to work, but my example doesn't use them so I haven't tested it 
> thoroughly"
> 
> HP
> 
> 
> 
> On Tue, Sep 20, 2016 at 11:37 AM, Larry Gritz <l...@larrygritz.com 
> <mailto:l...@larrygritz.com>> wrote:
> My bad, I think the reset line,
> 
>     buf.reset ("myrawfile.cr2", config=cfg)
> 
> will work if instead you write:
> 
>     buf.reset ("myrawfile.cr2", 0, 0, cfg)
> 
> I think I neglected to add the right instructions to let it understand the 
> default arguments and parameter names. I'll submit a separate patch for that.
> 
> I'm not sure I understand your comment about maximum_thr and camera_matrix -- 
> do you mean "they seem to work, but my example doesn't use them so I haven't 
> tested it thoroughly", or do you mean "my example uses them, but I see no 
> behavior change when I adjust them, so I suspect they are not working 
> properly?"
> 
> 
>> On Sep 19, 2016, at 11:57 PM, Haarm-Pieter Duiker <l...@duikerresearch.com 
>> <mailto:l...@duikerresearch.com>> wrote:
>> 
>> The pull request is behaving as expected for the attributes 
>> "raw:auto_bright", "raw:use_camera_wb", "raw:adjust_maximum_thr", 
>> "raw:use_camera_matrix" and "raw:ColorSpace".
>> 
>> "raw:adjust_maximum_thr" and "raw:use_camera_matrix" don't do much in my 
>> tests though.
>> 
>> The 'buf.reset' call from the Python path you outlined gives an error, 
>> copied below. The Python path from 
>> https://github.com/hpd/general/blob/master/hdr/python/mkhdr.py#L104 
>> <https://github.com/hpd/general/blob/master/hdr/python/mkhdr.py#L104>
>> works though.
>> 
>> HP
>> 
>> >>> buf.reset (inputPath, config=spec)
>> Traceback (most recent call last):
>>   File "<stdin>", line 1, in <module>
>> Boost.Python.ArgumentError: Python argument types in
>>     ImageBuf.reset(ImageBuf, str)
>> did not match C++ signature:
>>     reset(OpenImageIO::v1_7::ImageBuf {lvalue}, OpenImageIO::v1_7::ImageSpec)
>>     reset(OpenImageIO::v1_7::ImageBuf {lvalue}, std::__1::basic_string<char, 
>> std::__1::char_traits<char>, std::__1::allocator<char> >, int, int, 
>> OpenImageIO::v1_7::ImageSpec)
>>     reset(OpenImageIO::v1_7::ImageBuf {lvalue}, std::__1::basic_string<char, 
>> std::__1::char_traits<char>, std::__1::allocator<char> >, int, int)
>>     reset(OpenImageIO::v1_7::ImageBuf {lvalue}, std::__1::basic_string<char, 
>> std::__1::char_traits<char>, std::__1::allocator<char> >)
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> On Mon, Sep 19, 2016 at 2:23 PM, Larry Gritz <l...@larrygritz.com 
>> <mailto:l...@larrygritz.com>> wrote:
>> HP, does this look right to you? 
>> 
>> 
>>> On Sep 14, 2016, at 8:20 PM, Larry Gritz <l...@larrygritz.com 
>>> <mailto:l...@larrygritz.com>> wrote:
>>> 
>>> How does this look?  https://github.com/OpenImageIO/oiio/pull/1490 
>>> <https://github.com/OpenImageIO/oiio/pull/1490>
>>> 
>>> 
>>>> On Sep 13, 2016, at 9:41 PM, Haarm-Pieter Duiker <l...@duikerresearch.com 
>>>> <mailto:l...@duikerresearch.com>> wrote:
>>>> 
>>>> It looks like that 'adjust_maximum_thr' should be set to 0.0 generally. 
>>>> The comment from the libRaw changelog is as follows:
>>>> "
>>>>            * dcraw_emu's -c parameter now wants numeric (float) argument. 
>>>> This value
>>>>              is assigned to params.adjust_maximum_thr.
>>>>              Use -c 0.0 for dcraw compatibility.
>>>> 
>>>> "
>>>> It's odd that they overrode the -c command line option. With dcraw, that 
>>>> forces it to write data to stdout. dcraw_emu's -c option has completely 
>>>> different behavior.
>>>> 
>>>> Regardless, setting that struct value to 0.0 seems like it should be done 
>>>> as a matter of course.
>>>> 
>>>> HP
>>>> 
>>>> 
>>>> 
>>>> 
>>>> 
>>>> 
>>>> 
>>>> On Tue, Sep 13, 2016 at 12:36 AM, Kevin Wheatley 
>>>> <kevin.j.wheat...@gmail.com <mailto:kevin.j.wheat...@gmail.com>> wrote:
>>>> So here are the kinds of things we do...
>>>> 
>>>>     // Setup as much as possible to mean linear 16 bit
>>>>     RawProcessor.imgdata.params.output_bps = 16;
>>>>     RawProcessor.imgdata.params.ga 
>>>> <http://rawprocessor.imgdata.params.ga/>mm[0] = 1;
>>>>     RawProcessor.imgdata.params.ga 
>>>> <http://rawprocessor.imgdata.params.ga/>mm[1] = 1;
>>>>     RawProcessor.imgdata.params.no 
>>>> <http://rawprocessor.imgdata.params.no/>_auto_bright = 1;
>>>>     RawProcessor.imgdata.params.ad 
>>>> <http://rawprocessor.imgdata.params.ad/>just_maximum_thr = 0.0;
>>>> 
>>>>     // Some parameters effect open() and unpack()
>>>>     RawProcessor.imgdata.params.us 
>>>> <http://rawprocessor.imgdata.params.us/>e_camera_matrix = <variable>
>>>>     RawProcessor.imgdata.params.us 
>>>> <http://rawprocessor.imgdata.params.us/>e_camera_wb = <variable>
>>>> 
>>>> and some more parts... but those are the important colour ones, other
>>>> than intercepting the raw colour space buffer and calculating the
>>>> matrix multiplication ourselves in float to avoid clipping due to
>>>> white balance/etc.
>>>> 
>>>> Kevin
>>>> _______________________________________________
>>>> Oiio-dev mailing list
>>>> Oiio-dev@lists.openimageio.org <mailto:Oiio-dev@lists.openimageio.org>
>>>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org 
>>>> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
>>>> 
>>>> _______________________________________________
>>>> Oiio-dev mailing list
>>>> Oiio-dev@lists.openimageio.org <mailto:Oiio-dev@lists.openimageio.org>
>>>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org 
>>>> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
>>> 
>>> --
>>> Larry Gritz
>>> l...@larrygritz.com <mailto:l...@larrygritz.com>
>>> 
>>> 
>> 
>> --
>> Larry Gritz
>> l...@larrygritz.com <mailto:l...@larrygritz.com>
>> 
>> 
>> 
>> _______________________________________________
>> Oiio-dev mailing list
>> Oiio-dev@lists.openimageio.org <mailto:Oiio-dev@lists.openimageio.org>
>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org 
>> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
>> 
>> 
>> _______________________________________________
>> Oiio-dev mailing list
>> Oiio-dev@lists.openimageio.org <mailto:Oiio-dev@lists.openimageio.org>
>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org 
>> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
> 
> --
> Larry Gritz
> l...@larrygritz.com <mailto:l...@larrygritz.com>
> 
> 
> 
> _______________________________________________
> Oiio-dev mailing list
> Oiio-dev@lists.openimageio.org <mailto:Oiio-dev@lists.openimageio.org>
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org 
> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
> 
> 
> _______________________________________________
> Oiio-dev mailing list
> Oiio-dev@lists.openimageio.org
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org

--
Larry Gritz
l...@larrygritz.com


_______________________________________________
Oiio-dev mailing list
Oiio-dev@lists.openimageio.org
http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org

Reply via email to