The pull request is behaving as expected for the
attributes "raw:auto_bright", "raw:use_camera_wb",
"raw:adjust_maximum_thr", "raw:use_camera_matrix"
and "raw:ColorSpace".

"raw:adjust_maximum_thr" and "raw:use_camera_matrix" don't do much in my
tests though.

The 'buf.reset' call from the Python path you outlined gives an error,
copied below. The Python path from
https://github.com/hpd/general/blob/master/hdr/python/mkhdr.py#L104
works though.

HP

>>> buf.reset (inputPath, config=spec)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
Boost.Python.ArgumentError: Python argument types in
    ImageBuf.reset(ImageBuf, str)
did not match C++ signature:
    reset(OpenImageIO::v1_7::ImageBuf {lvalue},
OpenImageIO::v1_7::ImageSpec)
    reset(OpenImageIO::v1_7::ImageBuf {lvalue},
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >, int, int, OpenImageIO::v1_7::ImageSpec)
    reset(OpenImageIO::v1_7::ImageBuf {lvalue},
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >, int, int)
    reset(OpenImageIO::v1_7::ImageBuf {lvalue},
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >)






On Mon, Sep 19, 2016 at 2:23 PM, Larry Gritz <l...@larrygritz.com> wrote:

> HP, does this look right to you?
>
>
> On Sep 14, 2016, at 8:20 PM, Larry Gritz <l...@larrygritz.com> wrote:
>
> How does this look?  https://github.com/OpenImageIO/oiio/pull/1490
>
>
> On Sep 13, 2016, at 9:41 PM, Haarm-Pieter Duiker <l...@duikerresearch.com>
> wrote:
>
> It looks like that 'adjust_maximum_thr' should be set to 0.0 generally.
> The comment from the libRaw changelog is as follows:
> "
>            * dcraw_emu's -c parameter now wants numeric (float) argument.
> This value
>              is assigned to params.adjust_maximum_thr.
>              Use -c 0.0 for dcraw compatibility.
>
> "
> It's odd that they overrode the -c command line option. With dcraw, that
> forces it to write data to stdout. dcraw_emu's -c option has completely
> different behavior.
>
> Regardless, setting that struct value to 0.0 seems like it should be done
> as a matter of course.
>
> HP
>
>
>
>
>
>
>
> On Tue, Sep 13, 2016 at 12:36 AM, Kevin Wheatley <
> kevin.j.wheat...@gmail.com> wrote:
>
>> So here are the kinds of things we do...
>>
>>     // Setup as much as possible to mean linear 16 bit
>>     RawProcessor.imgdata.params.output_bps = 16;
>>     RawProcessor.imgdata.params.gamm[0] = 1;
>>     RawProcessor.imgdata.params.gamm[1] = 1;
>>     RawProcessor.imgdata.params.no_auto_bright = 1;
>>     RawProcessor.imgdata.params.adjust_maximum_thr = 0.0;
>>
>>     // Some parameters effect open() and unpack()
>>     RawProcessor.imgdata.params.use_camera_matrix = <variable>
>>     RawProcessor.imgdata.params.use_camera_wb = <variable>
>>
>> and some more parts... but those are the important colour ones, other
>> than intercepting the raw colour space buffer and calculating the
>> matrix multiplication ourselves in float to avoid clipping due to
>> white balance/etc.
>>
>> Kevin
>> _______________________________________________
>> Oiio-dev mailing list
>> Oiio-dev@lists.openimageio.org
>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>>
>
> _______________________________________________
> Oiio-dev mailing list
> Oiio-dev@lists.openimageio.org
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>
>
> --
> Larry Gritz
> l...@larrygritz.com
>
>
>
> --
> Larry Gritz
> l...@larrygritz.com
>
>
>
> _______________________________________________
> Oiio-dev mailing list
> Oiio-dev@lists.openimageio.org
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>
>
_______________________________________________
Oiio-dev mailing list
Oiio-dev@lists.openimageio.org
http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org

Reply via email to