I revisited this to see if anything had been done to make use of Tom's fix in the last 7 months since he contributed it. As best I can tell the answer is that the fix has been ignored. Of 15 ePubs I borrowed to check:
- 9 had the missing-pages corruption problem for which Tom's fix should be applied - 3 had some other sort of corruption that caused ADE to crash reliably with a null pointer exception (n.b. I'm using an old version of ADE in order to be able to run it under Wine, not being a Windows user, so this is not *neccessarily* OL's doing) - 3 were borrowable and appeared to have all the pages. Therefore only about 20% of the ePub database is usable, at least of the sort of books I read. Jon On Fri, Nov 06, 2015 at 10:16:33AM -0800, John Gonzalez wrote: > Thank you, Greg, Jon, and Tom. > > Please let me know if there are any obstacles to getting this fix introduced > into the code. > > I think we may need to include Gio in this, as I think that getting such a > fix into production on all incoming books may require some changes to other > parts of the Internet Archive code tree. > > -jcg > > John Gonzalez > Director, Engineering and Service Availability > j...@archive.org > > > > > On Nov 5, 2015, at 9:47 PM, Greg Lindahl <lind...@pbm.com> wrote: > > > > Thank you, Tom and Jon, for working on this despite the challenges! > > > > Tom, I have access to test your code against the list of examples that > > are in #31 and in the internal jira... I see your fork on github, and > > I will look at testing it on the raw scans next week. > > > > If you've spotted the correct part of the code, getting to a working > > fix should be straightforward. And an excellent example of how > > empowering the community can identify and fix bugs. > > > > Thanks again. > > > > -- greg > > _______________________________________________ > > Ol-tech mailing list > > ol-tech@archive.org > > http://mail.archive.org/cgi-bin/mailman/listinfo/ol-tech > > Archives: http://www.mail-archive.com/ol-tech@archive.org/ > > To unsubscribe from this mailing list, send email to > > ol-tech-unsubscr...@archive.org > _______________________________________________ > Ol-tech mailing list > ol-tech@archive.org > http://mail.archive.org/cgi-bin/mailman/listinfo/ol-tech > Archives: http://www.mail-archive.com/ol-tech@archive.org/ > To unsubscribe from this mailing list, send email to > ol-tech-unsubscr...@archive.org _______________________________________________ Ol-tech mailing list ol-tech@archive.org http://mail.archive.org/cgi-bin/mailman/listinfo/ol-tech Archives: http://www.mail-archive.com/ol-tech@archive.org/ To unsubscribe from this mailing list, send email to ol-tech-unsubscr...@archive.org