-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2909/#review3446
-----------------------------------------------------------
Overall, it's an important problem.
In every product, we could use some sub-dirs for future (such as lib/ conf/).
In other words, oozie should look into $SHARE_LIB/pig/lib/ for classes/jars.
Alternatively, we can coordinate this with multi-versions. There could be
multiple directories like $SHARELIB/pig/default/{lib, conf},
$SHARELIB/pig/0.7/{lib, conf}, $SHARELIB/pig/0.8/{lib, conf} etc. I'm leaning
towards this way to make it consistent with multi-version support.
/trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java
<https://reviews.apache.org/r/2909/#comment7693>
do we need it?
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java
<https://reviews.apache.org/r/2909/#comment7695>
so the name will be defined in each action. Or will it be better in the
system configuration in oozie-default(site).xml?
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java
<https://reviews.apache.org/r/2909/#comment7697>
Is hard-coding a good approach? Default could be "pig".
- Mohammad
On 2011-11-22 21:03:19, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2909/
> -----------------------------------------------------------
>
> (Updated 2011-11-22 21:03:19)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> breaks the Oozie sharelib into one subdir per action type
>
>
> This addresses bug OOZIE-610.
> https://issues.apache.org/jira/browse/OOZIE-610
>
>
> Diffs
> -----
>
> /trunk/core/pom.xml 1205165
> /trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java
> 1205165
>
> /trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
> 1205165
>
> /trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java
> 1205165
>
> /trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java
> 1205165
> /trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java
> 1205165
> /trunk/docs/src/site/twiki/DG_Examples.twiki 1205165
> /trunk/docs/src/site/twiki/DG_QuickStart.twiki 1205165
> /trunk/examples/pom.xml 1205165
> /trunk/examples/src/main/apps/custom-main/job.properties 1205165
> /trunk/examples/src/main/apps/demo/job.properties 1205165
> /trunk/examples/src/main/apps/hadoop-el/job.properties 1205165
> /trunk/examples/src/main/apps/java-main/job.properties 1205165
> /trunk/examples/src/main/apps/pig/job.properties 1205165
> /trunk/examples/src/main/apps/streaming/job.properties 1205165
> /trunk/pom.xml 1205165
> /trunk/sharelib/pig/pom.xml PRE-CREATION
> /trunk/sharelib/pom.xml 1205165
> /trunk/sharelib/streaming/pom.xml PRE-CREATION
> /trunk/src/main/assemblies/distro.xml 1205165
> /trunk/src/main/assemblies/examples.xml 1205165
> /trunk/src/main/assemblies/partial-sharelib.xml PRE-CREATION
> /trunk/src/main/assemblies/sharelib.xml 1205165
>
> Diff: https://reviews.apache.org/r/2909/diff
>
>
> Testing
> -------
>
> built, installed and run pig and streaming examples
>
>
> Thanks,
>
> Alejandro
>
>
