> On 2011-11-23 03:31:31, Mohammad Islam wrote: > > Overall comments: > > 1. Doing it incrementally will be good idea. But we need to consider the > > backward compatibility. For example, currently we are reading pig/*.jar, > > in the next oozie release, we decided to support pig/lib/*.jar or > > pig/0.8/lib/*.jar or pig/stable/lib/*.jar. In this case, the old setup will > > not work. > > > > 2. We wanted to support multiple version too. Virag has the patch. What is > > the best way of getting the benefits of both? > >
Backwards compatibility would not be an issue because when you change the layout of the library you'll change the resolution logic, and for jobs will be transparent. When you upgrade Oozie you'll have to upgrade the sharelib at the same time; but WF apps will be unaffected. Furthermore a migration path would be that now you are only supporting one version, 'stable', and later you'll support other versions via a configuration in the action XML. Alternate versions of libraries could be supported by a 'oozie.action.library.version' property in the action configuration, if not set it would resolve to 'stable', if set it would resolve to the version specified. This change is not complex, actually it is quite simple. What complicates things a bit is the packaging of sharelibs. Again, we could do this incremental (as in a couple of weeks), I just don't want to delay this patch much more as I have a patch chain (this, Hive, Sqoop, Alfredo) which takes time and work to keep up to date. > On 2011-11-23 03:31:31, Mohammad Islam wrote: > > /trunk/docs/src/site/twiki/DG_Examples.twiki, line 95 > > <https://reviews.apache.org/r/2909/diff/3/?file=59839#file59839line95> > > > > So user level libpath will not be supported? This is still supported, the examples are not using it anymore, instead they use the Oozie share lib. > On 2011-11-23 03:31:31, Mohammad Islam wrote: > > /trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java, > > line 192 > > <https://reviews.apache.org/r/2909/diff/3/?file=59838#file59838line192> > > > > why are we not reading the system library path for jars. There could be > > some system jars ,that are not any product specific (like pig, hive) but > > are commonly used. Also the question of backward compatibility is there. Is this a real scenario for you or hypothetical? If the latter then I would not worry as users can still use user set library paths. > On 2011-11-23 03:31:31, Mohammad Islam wrote: > > /trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java, line > > 30 > > <https://reviews.apache.org/r/2909/diff/3/?file=59834#file59834line30> > > > > But I don't see any other code changes in this file. My bad, thought the prev comment was for the JavaActionExecutor class, will remove. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2909/#review3459 ----------------------------------------------------------- On 2011-11-22 21:03:19, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2909/ > ----------------------------------------------------------- > > (Updated 2011-11-22 21:03:19) > > > Review request for oozie. > > > Summary > ------- > > breaks the Oozie sharelib into one subdir per action type > > > This addresses bug OOZIE-610. > https://issues.apache.org/jira/browse/OOZIE-610 > > > Diffs > ----- > > /trunk/core/pom.xml 1205165 > /trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java > 1205165 > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1205165 > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 1205165 > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 1205165 > /trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1205165 > /trunk/docs/src/site/twiki/DG_Examples.twiki 1205165 > /trunk/docs/src/site/twiki/DG_QuickStart.twiki 1205165 > /trunk/examples/pom.xml 1205165 > /trunk/examples/src/main/apps/custom-main/job.properties 1205165 > /trunk/examples/src/main/apps/demo/job.properties 1205165 > /trunk/examples/src/main/apps/hadoop-el/job.properties 1205165 > /trunk/examples/src/main/apps/java-main/job.properties 1205165 > /trunk/examples/src/main/apps/pig/job.properties 1205165 > /trunk/examples/src/main/apps/streaming/job.properties 1205165 > /trunk/pom.xml 1205165 > /trunk/sharelib/pig/pom.xml PRE-CREATION > /trunk/sharelib/pom.xml 1205165 > /trunk/sharelib/streaming/pom.xml PRE-CREATION > /trunk/src/main/assemblies/distro.xml 1205165 > /trunk/src/main/assemblies/examples.xml 1205165 > /trunk/src/main/assemblies/partial-sharelib.xml PRE-CREATION > /trunk/src/main/assemblies/sharelib.xml 1205165 > > Diff: https://reviews.apache.org/r/2909/diff > > > Testing > ------- > > built, installed and run pig and streaming examples > > > Thanks, > > Alejandro > >
