> On 2011-11-22 23:26:39, Mohammad Islam wrote:
> > Overall, it's an important problem.
> >
> > In every product, we could use some sub-dirs for future (such as lib/
> > conf/). In other words, oozie should look into $SHARE_LIB/pig/lib/ for
> > classes/jars.
> >
> > Alternatively, we can coordinate this with multi-versions. There could be
> > multiple directories like $SHARELIB/pig/default/{lib, conf},
> > $SHARELIB/pig/0.7/{lib, conf}, $SHARELIB/pig/0.8/{lib, conf} etc. I'm
> > leaning towards this way to make it consistent with multi-version support.
> >
> >
Yes, could have lib/ & conf/. However this is not a requirement at the moment,
and the change would be transparent when we need it. Like moving from a single
lib/ to a per-action one, users apps won't be affected.
Adding multi version support is a good idea. It would also require changes in
the action XML to specify the version.
Both could be future enhancements, but we should think more the use cases and
requirements. The current patch addresses an immediate need that could be
augmented later.
> On 2011-11-22 23:26:39, Mohammad Islam wrote:
> > /trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java, line
> > 30
> > <https://reviews.apache.org/r/2909/diff/3/?file=59834#file59834line30>
> >
> > do we need it?
yes, because of the signature of the getShareLibPostFix() method
> On 2011-11-22 23:26:39, Mohammad Islam wrote:
> > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java,
> > line 209
> > <https://reviews.apache.org/r/2909/diff/3/?file=59836#file59836line209>
> >
> > so the name will be defined in each action. Or will it be better in the
> > system configuration in oozie-default(site).xml?
this libraries are specific to an action type, thus it belongs to the action.
Making this configurable does not seem necessary at this point.
> On 2011-11-22 23:26:39, Mohammad Islam wrote:
> > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java,
> > line 140
> > <https://reviews.apache.org/r/2909/diff/3/?file=59837#file59837line140>
> >
> > Is hard-coding a good approach? Default could be "pig".
i'd start simple, later we can add more intelligence/configurability if we find
it necessary, as it is in a method already, the change will be transparent if
we do it.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2909/#review3446
-----------------------------------------------------------
On 2011-11-22 21:03:19, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2909/
> -----------------------------------------------------------
>
> (Updated 2011-11-22 21:03:19)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> breaks the Oozie sharelib into one subdir per action type
>
>
> This addresses bug OOZIE-610.
> https://issues.apache.org/jira/browse/OOZIE-610
>
>
> Diffs
> -----
>
> /trunk/core/pom.xml 1205165
> /trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java
> 1205165
>
> /trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
> 1205165
>
> /trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java
> 1205165
>
> /trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java
> 1205165
> /trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java
> 1205165
> /trunk/docs/src/site/twiki/DG_Examples.twiki 1205165
> /trunk/docs/src/site/twiki/DG_QuickStart.twiki 1205165
> /trunk/examples/pom.xml 1205165
> /trunk/examples/src/main/apps/custom-main/job.properties 1205165
> /trunk/examples/src/main/apps/demo/job.properties 1205165
> /trunk/examples/src/main/apps/hadoop-el/job.properties 1205165
> /trunk/examples/src/main/apps/java-main/job.properties 1205165
> /trunk/examples/src/main/apps/pig/job.properties 1205165
> /trunk/examples/src/main/apps/streaming/job.properties 1205165
> /trunk/pom.xml 1205165
> /trunk/sharelib/pig/pom.xml PRE-CREATION
> /trunk/sharelib/pom.xml 1205165
> /trunk/sharelib/streaming/pom.xml PRE-CREATION
> /trunk/src/main/assemblies/distro.xml 1205165
> /trunk/src/main/assemblies/examples.xml 1205165
> /trunk/src/main/assemblies/partial-sharelib.xml PRE-CREATION
> /trunk/src/main/assemblies/sharelib.xml 1205165
>
> Diff: https://reviews.apache.org/r/2909/diff
>
>
> Testing
> -------
>
> built, installed and run pig and streaming examples
>
>
> Thanks,
>
> Alejandro
>
>
