----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2909/#review3459 -----------------------------------------------------------
Overall comments: 1. Doing it incrementally will be good idea. But we need to consider the backward compatibility. For example, currently we are reading pig/*.jar, in the next oozie release, we decided to support pig/lib/*.jar or pig/0.8/lib/*.jar or pig/stable/lib/*.jar. In this case, the old setup will not work. 2. We wanted to support multiple version too. Virag has the patch. What is the best way of getting the benefits of both? /trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java <https://reviews.apache.org/r/2909/#comment7713> But I don't see any other code changes in this file. /trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/2909/#comment7716> Putting this condition earlier makes more sense. /trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java <https://reviews.apache.org/r/2909/#comment7715> it's ok /trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java <https://reviews.apache.org/r/2909/#comment7714> why are we not reading the system library path for jars. There could be some system jars ,that are not any product specific (like pig, hive) but are commonly used. Also the question of backward compatibility is there. /trunk/docs/src/site/twiki/DG_Examples.twiki <https://reviews.apache.org/r/2909/#comment7712> So user level libpath will not be supported? - Mohammad On 2011-11-22 21:03:19, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2909/ > ----------------------------------------------------------- > > (Updated 2011-11-22 21:03:19) > > > Review request for oozie. > > > Summary > ------- > > breaks the Oozie sharelib into one subdir per action type > > > This addresses bug OOZIE-610. > https://issues.apache.org/jira/browse/OOZIE-610 > > > Diffs > ----- > > /trunk/core/pom.xml 1205165 > /trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java > 1205165 > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1205165 > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 1205165 > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 1205165 > /trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1205165 > /trunk/docs/src/site/twiki/DG_Examples.twiki 1205165 > /trunk/docs/src/site/twiki/DG_QuickStart.twiki 1205165 > /trunk/examples/pom.xml 1205165 > /trunk/examples/src/main/apps/custom-main/job.properties 1205165 > /trunk/examples/src/main/apps/demo/job.properties 1205165 > /trunk/examples/src/main/apps/hadoop-el/job.properties 1205165 > /trunk/examples/src/main/apps/java-main/job.properties 1205165 > /trunk/examples/src/main/apps/pig/job.properties 1205165 > /trunk/examples/src/main/apps/streaming/job.properties 1205165 > /trunk/pom.xml 1205165 > /trunk/sharelib/pig/pom.xml PRE-CREATION > /trunk/sharelib/pom.xml 1205165 > /trunk/sharelib/streaming/pom.xml PRE-CREATION > /trunk/src/main/assemblies/distro.xml 1205165 > /trunk/src/main/assemblies/examples.xml 1205165 > /trunk/src/main/assemblies/partial-sharelib.xml PRE-CREATION > /trunk/src/main/assemblies/sharelib.xml 1205165 > > Diff: https://reviews.apache.org/r/2909/diff > > > Testing > ------- > > built, installed and run pig and streaming examples > > > Thanks, > > Alejandro > >
