[
https://issues.apache.org/jira/browse/OOZIE-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239029#comment-13239029
]
[email protected] commented on OOZIE-477:
-----------------------------------------------------
bq. On 2012-03-23 20:46:30, Alejandro Abdelnur wrote:
bq. > the FSActionExecutor is checking for the allowed filesystem schemes. It
seems the JavaActionExecutor and the submit job command should do the same, no?
In earlier code, the FsActionExecutor had hardcoding of "hdfs://" scheme. This
patch is mainly directed to remove that hardcoding and allow flexibility in
schemes, through configuration. There can be other places too, in addition to
JavaActionExecutor where code change is required for federation. I am opening
another JIRA to address that requirement.
bq. On 2012-03-23 20:46:30, Alejandro Abdelnur wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java,
line 97
bq. > <https://reviews.apache.org/r/2059/diff/6/?file=94571#file94571line97>
bq. >
bq. > this is a non-relevant change. please revert
ok
bq. On 2012-03-23 20:46:30, Alejandro Abdelnur wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java,
line 102
bq. > <https://reviews.apache.org/r/2059/diff/6/?file=94571#file94571line102>
bq. >
bq. > same same
ok
bq. On 2012-03-23 20:46:30, Alejandro Abdelnur wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java,
line 98
bq. > <https://reviews.apache.org/r/2059/diff/6/?file=94568#file94568line98>
bq. >
bq. > we should read/parse/trim the supported filesystem schemes once (at
init time, or first time) and then cache the array
agreed. otherwise the config property - supported schemes, is being retrieved
repeatedly. fixed.
bq. On 2012-03-23 20:46:30, Alejandro Abdelnur wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java,
line 1114
bq. > <https://reviews.apache.org/r/2059/diff/6/?file=94569#file94569line1114>
bq. >
bq. > where is this method used?
removing method since it is not used.
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6307
-----------------------------------------------------------
On 2012-03-22 17:27:37, Mona Chitnis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2059/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-22 17:27:37)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch was originally worked on by Mayank Bansal.
bq. I (Mona Chitnis) am in charge of handling this review request.
bq.
bq. Description - adding hadoop.next support for oozie
bq.
bq.
bq. This addresses bug OOZIE-477.
bq. https://issues.apache.org/jira/browse/OOZIE-477
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java
1303609
bq. trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java
1303609
bq.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
1303609
bq.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
1303609
bq.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java
1303609
bq.
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java
1303609
bq. trunk/core/src/main/resources/oozie-default.xml 1303609
bq.
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java
1303609
bq.
bq. Diff: https://reviews.apache.org/r/2059/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. tested against current unit tests
bq.
bq.
bq. Thanks,
bq.
bq. Mona
bq.
bq.
> Adding configurable filesystem support instead of hardcoded "hdfs"
> ------------------------------------------------------------------
>
> Key: OOZIE-477
> URL: https://issues.apache.org/jira/browse/OOZIE-477
> Project: Oozie
> Issue Type: Bug
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
>
> This allows for configurable filesystem support in Hadoop 23 and not only
> "hdfs://".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
