[
https://issues.apache.org/jira/browse/OOZIE-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241123#comment-13241123
]
[email protected] commented on OOZIE-477:
-----------------------------------------------------
bq. On 2012-03-28 19:47:57, Alejandro Abdelnur wrote:
bq. > I think my previous comment on the WFApp not checking the supported
filesystems was not fully understood.
bq. >
bq. > We should check that the app path is for a supported filesystem and fail
if not. else people could write WFs in the local filesystem or NFS and loaded
from Oozie. This should be possible only if it is a supported filesystem
added the Wf app path check. To avoid code repetition, defined this logic of
"checkSupportedFilesystem" in parent class ActionExecutor and invoking from
JavaAE and FsAE. Modified/added respective testcases.
bq. On 2012-03-28 19:47:57, Alejandro Abdelnur wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java,
line 358
bq. > <https://reviews.apache.org/r/2059/diff/8/?file=97129#file97129line358>
bq. >
bq. > this should be done once, if supportedSchemes is null. it should be
done within a synchronized block:
bq. >
bq. > synch {
bq. > if (supportedSchemes == null) {
bq. > ///load
bq. > }
bq. > }
bq. >
bq. > this would create minimum contention as there is no logic at all
after the first pass that loads the supported schemes
done
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6487
-----------------------------------------------------------
On 2012-03-28 00:14:46, Mona Chitnis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2059/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-28 00:14:46)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch was originally worked on by Mayank Bansal.
bq. I (Mona Chitnis) am in charge of handling this review request.
bq.
bq. Description - adding hadoop.next support for oozie
bq.
bq.
bq. This addresses bug OOZIE-477.
bq. https://issues.apache.org/jira/browse/OOZIE-477
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java
1303609
bq.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
1303609
bq.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java
1303609
bq.
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java
1303609
bq. trunk/core/src/main/resources/oozie-default.xml 1303609
bq.
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java
1303609
bq.
bq. Diff: https://reviews.apache.org/r/2059/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. tested against current unit tests
bq.
bq.
bq. Thanks,
bq.
bq. Mona
bq.
bq.
> Adding configurable filesystem support instead of hardcoded "hdfs"
> ------------------------------------------------------------------
>
> Key: OOZIE-477
> URL: https://issues.apache.org/jira/browse/OOZIE-477
> Project: Oozie
> Issue Type: Bug
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
>
> This allows for configurable filesystem support in Hadoop 23 and not only
> "hdfs://".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
