[ 
https://issues.apache.org/jira/browse/OOZIE-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240672#comment-13240672
 ] 

[email protected] commented on OOZIE-477:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6487
-----------------------------------------------------------


I think my previous comment on the WFApp not checking the supported filesystems 
was not fully understood.

We should check that the app path is for a supported filesystem and fail if 
not. else people could  write WFs in the local filesystem or NFS and loaded 
from Oozie. This should be possible only if it is a supported filesystem


trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
<https://reviews.apache.org/r/2059/#comment14136>

    this should be done once, if supportedSchemes is null. it should be done 
within a synchronized block:
    
    synch {
      if (supportedSchemes == null) {
       ///load
      }
    }
    
    this would create minimum contention as there is no logic at all after the 
first pass that loads the supported schemes


- Alejandro


On 2012-03-28 00:14:46, Mona Chitnis wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2059/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-28 00:14:46)
bq.  
bq.  
bq.  Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This patch was originally worked on by Mayank Bansal. 
bq.  I (Mona Chitnis) am in charge of handling this review request.
bq.  
bq.  Description - adding hadoop.next support for oozie
bq.  
bq.  
bq.  This addresses bug OOZIE-477.
bq.      https://issues.apache.org/jira/browse/OOZIE-477
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java 
1303609 
bq.    
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 
1303609 
bq.    
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 
1303609 
bq.    
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 
1303609 
bq.    trunk/core/src/main/resources/oozie-default.xml 1303609 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java
 1303609 
bq.  
bq.  Diff: https://reviews.apache.org/r/2059/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  tested against current unit tests
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Mona
bq.  
bq.


                
> Adding configurable filesystem support instead of hardcoded "hdfs"
> ------------------------------------------------------------------
>
>                 Key: OOZIE-477
>                 URL: https://issues.apache.org/jira/browse/OOZIE-477
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Mayank Bansal
>            Assignee: Mayank Bansal
>
> This allows for configurable filesystem support in Hadoop 23 and not only 
> "hdfs://". 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to