[
https://issues.apache.org/jira/browse/OOZIE-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241142#comment-13241142
]
[email protected] commented on OOZIE-477:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2059/#review6513
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
<https://reviews.apache.org/r/2059/#comment14168>
wasn't this going to be addressed by another JIRA?
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
<https://reviews.apache.org/r/2059/#comment14169>
the synchronization cannot be on the current action instance as actions are
created every time they are needed. the synchronization should be on something
global, ie the class hosting this method
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
<https://reviews.apache.org/r/2059/#comment14170>
again, this is suppose to be part of another JIRA, no?
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/2059/#comment14171>
this code is duplicated in FSActionExecutor, it seems it should be factored
out and reused.
Furthermore, should this be loaded then by the ActionExecutor class itself?
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java
<https://reviews.apache.org/r/2059/#comment14172>
what am i missing? i still don't see the scheme being check here.
- Alejandro
On 2012-03-29 10:29:06, Mona Chitnis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2059/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-29 10:29:06)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch was originally worked on by Mayank Bansal.
bq. I (Mona Chitnis) am in charge of handling this review request.
bq.
bq. Description - adding hadoop.next support for oozie
bq.
bq.
bq. This addresses bug OOZIE-477.
bq. https://issues.apache.org/jira/browse/OOZIE-477
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java
1303609
bq.
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java
1303609
bq.
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java
1303609
bq. trunk/core/src/main/resources/oozie-default.xml 1303609
bq.
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java
1303609
bq.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java
1303609
bq.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
1303609
bq. trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java
1303609
bq. trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java
1303609
bq.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
1303609
bq.
bq. Diff: https://reviews.apache.org/r/2059/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. tested against current unit tests
bq.
bq.
bq. Thanks,
bq.
bq. Mona
bq.
bq.
> Adding configurable filesystem support instead of hardcoded "hdfs"
> ------------------------------------------------------------------
>
> Key: OOZIE-477
> URL: https://issues.apache.org/jira/browse/OOZIE-477
> Project: Oozie
> Issue Type: Bug
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
>
> This allows for configurable filesystem support in Hadoop 23 and not only
> "hdfs://".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
