On Sep 4, 2008, at 11:04, Mark Marshall wrote:
Hi.
Hi!
After a long absence, I now have a new PC. I have also written a
rough framework for a VGA BIOS. It is very far from complete, but
I'd like to show that I've done something and get some feedback on it.
I'm new to Open Source development, so this is very exciting (I have
to tell myself that otherwise it would be just like being at work).
At the moment I set-up the registers for mode 0x03 and support a
couple of other BIOS calls - most notably int 0x10, function 0x0E
(which is what DOS uses to print a character). Almost everything
else is still TODO.
Let me start of by thanking you for your effort. However, I've got a
few blunt questions. Here goes. :)
0) These all look like new files. Don't bother with a diff in that
case, just give a folder with the files. Diffs are readable, but only
if you're actually making changes to existing stuff IMHO.
1) How much of this code is original and written by you? I see loads
of data structs which I doubt are all written by you, and simply
tagging it with the dual license might be a problem.
2) I noticed it doesn't contain any OGD1 specific code except for
ogd_reg_defines.inc, but I don't see this actually being used
anywhere. This is OK, but makes me wonder what all these functions are
for really. If it's all placeholder code to keep bochs happy for the
moment, I wonder how much effort I should be spending at trying to
understand it all.
3) I see a bunch of typo's in the comments but can't be bothered to
clean them up yet. Just saying. :)
4) I predict a lengthy discussion about the fntcol16.zip comment.
Cheers,
Michael
PS: I just started my final internship this week, no more classes!
More OGP time! o//
PPS: Just checked out the latest revision, the contact cards are in
there! Neat, didn't know they ended up there. I hereby claim to be the
original author of those documents and give permission for using those
files under the Traversal Dual license yada yada yada.
_______________________________________________
Open-graphics mailing list
[email protected]
http://lists.duskglow.com/mailman/listinfo/open-graphics
List service provided by Duskglow Consulting, LLC (www.duskglow.com)
