Try reply all next time ;)
Begin forwarded message:
From: Mark Marshall <snip>
Date: September 4, 2008 20:25:51 GMT+02:00
To: Michael Meeuwisse <snip>
Subject: Re: [Open-graphics] BIOS framework written
Michael Meeuwisse wrote:
0) These all look like new files. Don't bother with a diff in that
case, just give a folder with the files. Diffs are readable, but
only if you're actually making changes to existing stuff IMHO.
Yes, they are all new files, I just wasn't sure what to do with
them. (zcat | sed -e 's/^+//' | less ?)
1) How much of this code is original and written by you? I see
loads of data structs which I doubt are all written by you, and
simply tagging it with the dual license might be a problem.
As I said in my previous e-mail, all the code was written by me.
The structure definitions were all typed in by (my) hand(s). Some
of the Vesa structures were copied from the PDF's and then modified
to have the same capitalisation as the others, I'm assuming that
things like structure definitions that come from freely available
specifications are not really things that can be copyrighted.
I have read a lot of books and papers on programming a PC / VGA
graphics card, and some of them might have been opened recently, but
the code is all mine.
Just out of interest, are we sure that this is true. If for
instance I describe in code and comments exactly how some part of
the PCI specification works, are the PCI SIG going to be cross that
we've released internal information about how their "pay for" spec
works. I'm sure that OS software must have this issue all the time,
and the PCI spec is available on google (for those of you without a
company license), but I also know that the SDIO sig were quite a
pain over this.
2) I noticed it doesn't contain any OGD1 specific code except for
ogd_reg_defines.inc, but I don't see this actually being used
anywhere. This is OK, but makes me wonder what all these functions
are for really. If it's all placeholder code to keep bochs happy
for the moment, I wonder how much effort I should be spending at
trying to understand it all.
You're right, as I thought I said, there is no OGD specific code
here yet. This does nothing of any interest at all [*]. It's just
a line under the sand (to mix my metaphors). Don't bother to spend
too much time trying to understand it, it's just the start of a VGA
BIOS.
3) I see a bunch of typo's in the comments but can't be bothered to
clean them up yet. Just saying. :)
Yeah, you sound like my boss. I'll try to do my best (but I thought
I was following the house style ;-).
4) I predict a lengthy discussion about the fntcol16.zip comment.
Yep, I was worried about where to get a font from. I googled and
found the package fntcol16.zip, and read the text inside and it said
it was legit, so I took it on it's word. There's nothing special
about it, we can drop in anything else we want if you would rather.
I know that Linux must contain fonts, because the font changes early
on in the boot process, so I can dig around and try to grab that one
if you'd rather. I didn't include it in our repository for this
reason.
MM
PS.
What's happened to project VGA?
[*]
It proves that I have a basic understanding of how a VGA BIOS works,
and am willing to put some effort in to writing one for OGD.
_______________________________________________
Open-graphics mailing list
[email protected]
http://lists.duskglow.com/mailman/listinfo/open-graphics
List service provided by Duskglow Consulting, LLC (www.duskglow.com)
