Hi Mike, No problems, I will look over the source and submit fixes and integrate the needed Broadcom user-space library code into libuip.
Thanks Rakesh integrating the uIP code into the open-iscsi tree! -Ben On Sat, 2009-08-15 at 19:53 -0700, Mike Christie wrote: > On 07/24/2009 08:06 AM, Rakesh Ranjan wrote: > > Mike Christie wrote: > >> Sorry for the really late response on this. > >> > >> On 06/25/2009 08:25 AM, Rakesh Ranjan wrote: > >>> Li, I have attached the diff against git master, please go through it. I > >>> have merged the contents of uip directory and nic related files into one > >>> common libuip. So now offload dir looks like > >>> > >>> offload/drivers > >>> offload/libuip > >>> > >>> Mike, what are your thoughts about linking uip core code int iscsid. > >>> Weather it gonna be static or dynamic ? Also it would be very helpful if > >> I think we would want to do it static, because it will make the distro > >> boot and installer stuff easier. > >> > >>> you could help on adding additional iface options. > >>> > >>> Regards > >>> Rakesh Ranjan > >> Was the attached patch ok for a starting point? I will cleanup the > >> open-iscsi/user and include stuff and add the uip stuff as is and then > >> put it in a new branch for us to work off of. > > > > Hi Mike, > > > > Herein attached the latest patch against current master. I have made > > libuip part to be static, but userspace driver part is still dynamic. I > > think this way vendor can drop in their driver as shared library. > > > > I will merge it this way, but we have to set some rules about where the > modules will live so distros do not have to search the ifaces. > > > I did some clean up and added a fixed I had for initiator.c. > > Ben, this code does not support bnx2i. Could you add that and add fixes > you have in your standalone code? > > Oh yeah, this is in the open-iscsi git tree's offload branch so clone > the tree like normal then do > > git branch -a > git checkout origin/offload > git checkout -b my_offload > > > Rakesh thanks again for doing this. And Ben, thanks for your work on > bcrm uip and for adding bnx2i to this. > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to firstname.lastname@example.org To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~----------~----~----~----~------~----~------~--~---