When for example adding an other package mananger a two rows deltask do_package_write_PKGMGR deltask do_package_write_PKGMGR_setscene is needed to be added to nopackages.bbclass. When adding the new package manager in a new layer in order to extend poky (rather than forking it) the whole nopackages.bbclass needs to be copied which is a maintenance problem. Moving nopackages.bbclass to nopackages.bbclass would make the new layer just adding an image.bbclass containing: inherit nopackages_base.bbclass deltask do_package_write_PKGMGR deltask do_package_write_PKGMGR_setscene
Which is much easier to maintain. Signed-off-by: Fredrik Gustafsson <fredr...@axis.com> --- meta/classes/nopackages.bbclass | 15 +++------------ meta/classes/nopackages_base.bbclass | 12 ++++++++++++ 2 files changed, 15 insertions(+), 12 deletions(-) create mode 100644 meta/classes/nopackages_base.bbclass diff --git a/meta/classes/nopackages.bbclass b/meta/classes/nopackages.bbclass index 559f5078bd..78bbd8c85c 100644 --- a/meta/classes/nopackages.bbclass +++ b/meta/classes/nopackages.bbclass @@ -1,12 +1,3 @@ -deltask do_package -deltask do_package_write_rpm -deltask do_package_write_ipk -deltask do_package_write_deb -deltask do_package_qa -deltask do_packagedata -deltask do_package_setscene -deltask do_package_write_rpm_setscene -deltask do_package_write_ipk_setscene -deltask do_package_write_deb_setscene -deltask do_package_qa_setscene -deltask do_packagedata_setscene +# This file should only inherit nopackages_base. This is to make +# this file easy to extend from an other layer. +inherit nopackages_base diff --git a/meta/classes/nopackages_base.bbclass b/meta/classes/nopackages_base.bbclass new file mode 100644 index 0000000000..e898cef00f --- /dev/null +++ b/meta/classes/nopackages_base.bbclass @@ -0,0 +1,12 @@ +deltask do_package +deltask do_package_qa +deltask do_packagedata +deltask do_package_setscene +deltask do_package_qa_setscene +deltask do_packagedata_setscene +deltask do_package_write_rpm +deltask do_package_write_deb +deltask do_package_write_ipk +deltask do_package_write_rpm_setscene +deltask do_package_write_deb_setscene +deltask do_package_write_ipk_setscene -- 2.20.1
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#139824): https://lists.openembedded.org/g/openembedded-core/message/139824 Mute This Topic: https://lists.openembedded.org/mt/75057634/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
