On Tue, 2020-06-23 at 13:13 +0200, Fredrik Gustafsson wrote: > Today OE-Core has support for three package managers, even if there > are many more package managers that could be interesting to use. > Adding a new package manager to OE-Core would increase the test matrix > significantly. In order to let users use their favorite package manager > without need for it to have support from upstream, this patch refactors > the package manager code so that it's easy to add a new package > manager in another layer. > > This patch is mostly moving code and duplicating some code (because of > the hard coupling between deb and ipk). > > Signed-off-by: Fredrik Gustafsson <fredr...@axis.com> > --- > meta/classes/populate_sdk_base.bbclass | 11 +- > meta/lib/oe/manifest.py | 149 +- > meta/lib/oe/package_manager.py | 1402 +---------------- > meta/lib/oe/package_managers/deb/manifest.py | 31 + > .../package_managers/deb/package_manager.py | 719 +++++++++ > meta/lib/oe/package_managers/deb/rootfs.py | 213 +++ > meta/lib/oe/package_managers/deb/sdk.py | 97 ++ > .../ipk/.package_manager.py.swo | Bin 0 -> 45056 bytes > meta/lib/oe/package_managers/ipk/manifest.py | 79 + > .../package_managers/ipk/package_manager.py | 588 +++++++ > meta/lib/oe/package_managers/ipk/rootfs.py | 395 +++++ > meta/lib/oe/package_managers/ipk/sdk.py | 104 ++ > meta/lib/oe/package_managers/rpm/manifest.py | 62 + > .../package_managers/rpm/package_manager.py | 423 +++++ > meta/lib/oe/package_managers/rpm/rootfs.py | 154 ++ > meta/lib/oe/package_managers/rpm/sdk.py | 104 ++ > meta/lib/oe/rootfs.py | 631 +------- > meta/lib/oe/sdk.py | 311 +--- > meta/lib/oeqa/utils/package_manager.py | 29 +- > meta/recipes-core/meta/package-index.bb | 2 +- > 20 files changed, 3014 insertions(+), 2490 deletions(-)
I'm afraid this patch is basically impossible to review. There are warning signs like the inclusion of the binary swo file. The hint that code gets duplicated also worries me, even if you abstract this, there shouldn't be reason to do that. If we do this its going to have to be a more granular series where the patches *just* move code to new locations so we can see/understand what other changes are being made as I simply don't trust this patch, sorry :(. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#139829): https://lists.openembedded.org/g/openembedded-core/message/139829 Mute This Topic: https://lists.openembedded.org/mt/75057635/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
