On Tue, 2020-06-23 at 13:13 +0200, Fredrik Gustafsson wrote: > When for example adding an other package mananger a two rows > deltask do_package_write_PKGMGR > deltask do_package_write_PKGMGR_setscene > is needed to be added to nopackages.bbclass. When adding the new > package > manager in a new layer in order to extend poky (rather than forking > it) > the whole nopackages.bbclass needs to be copied which is a > maintenance > problem. Moving nopackages.bbclass to nopackages.bbclass would make > the > new layer just adding an image.bbclass containing: > inherit nopackages_base.bbclass > deltask do_package_write_PKGMGR > deltask do_package_write_PKGMGR_setscene > > Which is much easier to maintain. > > Signed-off-by: Fredrik Gustafsson <fredr...@axis.com> > --- > meta/classes/nopackages.bbclass | 15 +++------------ > meta/classes/nopackages_base.bbclass | 12 ++++++++++++ > 2 files changed, 15 insertions(+), 12 deletions(-) > create mode 100644 meta/classes/nopackages_base.bbclass
I personally think "_base" bbclasses are not helpful to making our code easier to understand and I'd prefer to see fewer of them, not more. I can't remember if deltask support multiple parameters but if not, it can be made to. That would then allow this to be configured with a variable. I'd suggest we explore other options along those lines for this. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#139828): https://lists.openembedded.org/g/openembedded-core/message/139828 Mute This Topic: https://lists.openembedded.org/mt/75057634/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
