On Mon, 15 Jan 2024 at 14:41, Ross Burton <[email protected]> wrote: > > On 9 Jan 2024, at 19:29, Khem Raj via lists.openembedded.org > <[email protected]> wrote: > > ++ #ifndef BACKEND_IS_OPENSSL > > + g_test_add ("/tls/" BACKEND "/connection/unclean-close-by-server", > > TestConnection, NULL, > > + setup_connection, test_unclean_close_by_server, > > teardown_connection); > > ++ #endif > > Personally, unless upstream say “yes this test doesn’t work on openssl yet” > and mark it as such, this is still a test failure that is failing for unknown > reasons. > > We could #if 0 out every test that failed and rejoice in our 100% pass test > cases but that would be a terrible idea, so why is this different?
This is what we already do for intermittently failing ptests all over the stack. Rejoice! This issue is reported upstream, and the link is in the patch. Yes, given sufficient time one can become an expert in intricacies of glib, openssl, and their interaction, and then develop a real fix all by themselves, but I think a more fair expectation is exactly what Khem is doing: report upstream, add a reasonable workaround, follow up upstream requests in the reported ticket. Alex
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#193675): https://lists.openembedded.org/g/openembedded-core/message/193675 Mute This Topic: https://lists.openembedded.org/mt/103626740/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
