On Mon, Jan 15, 2024 at 5:41 AM Ross Burton <[email protected]> wrote:
> On 9 Jan 2024, at 19:29, Khem Raj via lists.openembedded.org <raj.khem= > [email protected]> wrote: > > ++ #ifndef BACKEND_IS_OPENSSL > > + g_test_add ("/tls/" BACKEND "/connection/unclean-close-by-server", > TestConnection, NULL, > > + setup_connection, test_unclean_close_by_server, > teardown_connection); > > ++ #endif > > Personally, unless upstream say “yes this test doesn’t work on openssl > yet” and mark it as such, this is still a test failure that is failing for > unknown reasons. > > We could #if 0 out every test that failed and rejoice in our 100% pass > test cases but that would be a terrible idea, so why is this different? > This however is not the case here. Upstream has accepted the bug already and marked it so as well. I am not sure why we should act more stricter in accepting patches than upstream activity here. > Ross
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#193687): https://lists.openembedded.org/g/openembedded-core/message/193687 Mute This Topic: https://lists.openembedded.org/mt/103626740/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
