Hi Michael, please see inline. Cheers, Uli
> -----Original Message----- > From: ext Bishop, Michael (ISB Linux/Telco) > [mailto:[email protected]] > Sent: Wednesday, June 09, 2010 6:26 PM > To: '[email protected]' > Subject: Re: [Openhpi-devel] [ openhpi-Bugs-3011456 ] > DomainSupport forClients > > Uli - > > Thanks for the update. > > Here's what I'd like to see: > > 1. All code changes are backward compatible - so, for > instance, a user can still run hpitop or hpitree without any > options - and still get the default domain as before. Also, > a user should not be required to configure openhpiclient.conf > in order to use the client programs. In other words, we do > not want to make the OpenHPI clients harder to use. Yes, that's cared for. The clients don't use openhpiclient.conf at all. Actually, the option -D works in a very simple way. The given domainid is used in saHpiSessionOpen(). If the given domain is not defined the call is rejected by the baselib. If the -D is not used, the clients call saHpiSessionOpen using SAHPI_UNSPECIFIED_DOMAIN_ID as it is today. So all clients can be used as before. One exception: I fixed some bugs like: - hpitree -n requires a value. There was no check. Now there will be a printout of the usage text when there is no value given, instead of ignoring the option. > > 2. All client changes are tested, and checked-in by Monday, June 14. > > Please note that one of the release criteria for OpenHPI is > that all of the OpenHPI clients must work. So we strongly > depend on the clients as part of releasing OpenHPI. Ok. I try to check that also the existing options still work. That's why I got confused with hpiinv. > > I'll be happy to review the patches you create. Please post > them to the OpenHPI developer list as soon as you can. Once > they are reviewed, please check them into the top-of-trunk. > > On hpiinv - please post a defect or enhancement request on > the issue you are seeing with the -v option. We can always > look into this issue at a future release so that you are not > getting sidetracked while you make your intended edits to the > client programs. Yes. For that I need to test it a bit more. > > Note that there are 16 OpenHPI client programs - so if you > feel this is too much change for 2.15.0 in the short amount > of time that is left - you can always do these changes in a > later release. Please keep this in mind if the work proves > to be more time consuming than you originally estimated. The 16th is hpigensimdata. I think I need to send the patch to Lars for that, so he can use his newest version. Cheers, Uli > > --michael > > Regards, > Michael Bishop > Enterprise Servers and Storage (ISB Linux/Telco) > Hewlett-Packard Company > 3404 E. Harmony Rd. Bldg. 5L, Post B7, Mailstop 42 > Fort Collins, CO 80528-9599 > Phone: 970-898-4393 > E-Mail: [email protected] > > > > > > -----Original Message----- > > From: Kleber, Ulrich (NSN - DE/Munich) > [mailto:[email protected]] > > Sent: Tuesday, June 08, 2010 11:55 PM > > To: [email protected] > > Subject: Re: [Openhpi-devel] [ openhpi-Bugs-3011456 ] Domain Support > > forClients > > > > > > Hi Michael, > > yes, Anton is right. I plan changes for 2.15.0 only for the clients > > hpitop, hpitree, etc. So no changes to main code. > > But I wanted to introduce the -D option for all clients, so it is > > some editing work to do, which I could do easily till next Monday - > > if I don't find other problems. > > I sometimes find options that are implemtented but not > > documented in the > > usage or man. So I try to fix that, too. > > And yesterday I started on hpiinv and got the feeling that > -v doesn't > > work properly. Somehow the output without -v seems more verbose than > > with the option. > > > > I didn't do checkin on svn yet. Is it easy to do or can I send you > > a patch or tar instead? The changes are not big and can still be > > done using patch (~ 80 lines per client). > > > > Cheers, > > Uli > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > From: ext Bishop, Michael (ISB Linux/Telco) > > > [mailto:[email protected]] > > > Sent: Tuesday, June 08, 2010 7:16 PM > > > To: '[email protected]' > > > Subject: Re: [Openhpi-devel] [ openhpi-Bugs-3011456 ] Domain > > > Support forClients > > > > > > Anton - > > > > > > Thanks for clarifying. I would still like to hear from Uli > > > on his view of getting this work done in time for 2.15.0. > > > > > > --michael > > > > > > > > > > > > > -----Original Message----- > > > > From: [email protected] > [mailto:[email protected]] > > > > Sent: Tuesday, June 08, 2010 11:01 AM > > > > To: [email protected] > > > > Subject: Re: [Openhpi-devel] [ openhpi-Bugs-3011456 ] > > Domain Support > > > > forClients > > > > > > > > > > > > Michael, > > > > > > > > I guess we decided to split this bussiness into several steps. > > > > The first one (which I believe will go into 2.15.0) is to > > > > add -D parameter in OpenHPI clients (hpitop, hpitree ...). > > > > So base library, daemon and plug-ins will be intact. > > > > > > > > Anton Pak > > > > > > > > > Uli - > > -------------------------------------------------------------- > ---------------- > ThinkGeek and WIRED's GeekDad team up for the Ultimate > GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the > lucky parental unit. See the prize list and enter to win: > http://p.sf.net/sfu/thinkgeek-promo > _______________________________________________ > Openhpi-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/openhpi-devel > ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Openhpi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openhpi-devel
